[ML] Alerting rule for Anomaly Detection jobs monitoring #106084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
:ml
Feature:Anomaly Detection
darnautov
requested review from
peteharverson,
ymao1,
jgowdyelastic and
szabosteve
|
Pinging @elastic/ml-ui (:ml) |
| @@ -38,6 +42,8 @@ export type SharedServices = JobServiceProvider & | |||
| ResultsServiceProvider & | |||
| MlAlertingServiceProvider; | |||
|
|
|||
| export type MlServicesProviders = JobsHealthServiceProvider; | |||
There was a problem hiding this comment.
There a bit of inconsistency with the naming, perhaps this should be called internalServices or something like that?
Something that is more obvious when compared to SharedServices above.
There was a problem hiding this comment.
Renamed in 5f886cb
ymao1
reviewed
Jul 21, 2021
x-pack/plugins/ml/server/lib/alerts/register_jobs_monitoring_rule_type.ts
Show resolved
Hide resolved
…onal-alerting-rule
jgowdyelastic
approved these changes
Jul 21, 2021
peteharverson
approved these changes
Jul 22, 2021
|
@elasticmachine merge upstream |
…ule' into ml-101028-operational-alerting-rule
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @darnautov |
💔 Backport failed
To backport manually run: |
This was referenced Jul 22, 2021
Merged
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Jul 26, 2021
) * [ML] init job health alerting rule type * [ML] add health checks selection ui * [ML] define schema * [ML] support all jobs selection * [ML] jobs health service * [ML] add logger * [ML] add context message * [ML] fix default message for i18n * [ML] check response size * [ML] add exclude jobs control * [ML] getResultJobsHealthRuleConfig * [ML] change naming for shared services * [ML] fix excluded jobs filtering * [ML] check for execution results * [ML] update context fields * [ML] unit tests for getResultJobsHealthRuleConfig * [ML] refactor and job ids check * [ML] rename datafeed * [ML] fix translation messages * [ML] hide non-implemented tests * [ML] remove jod ids join from the getJobs call * [ML] add validation for the tests config * [ML] fix excluded jobs udpate * [ML] update jobIdsDescription message * [ML] allow selection all jobs only for include * [ML] better ux for excluded jobs setup * [ML] change rule type name * [ML] fix typo * [ML] change instances names * [ML] fix messages * [ML] hide error callout, show health checks error in EuiFormRow * [ML] add check for job state * [ML] add alertingRules key to the doc links * [ML] update types * [ML] remove redundant type * [ML] fix job and datafeed states check * [ML] fix job and datafeed states check, add comments * [ML] add unit tests # Conflicts: # src/core/public/doc_links/doc_links_service.ts
darnautov
added a commit
that referenced
this pull request
Jul 26, 2021
…106675) * [ML] init job health alerting rule type * [ML] add health checks selection ui * [ML] define schema * [ML] support all jobs selection * [ML] jobs health service * [ML] add logger * [ML] add context message * [ML] fix default message for i18n * [ML] check response size * [ML] add exclude jobs control * [ML] getResultJobsHealthRuleConfig * [ML] change naming for shared services * [ML] fix excluded jobs filtering * [ML] check for execution results * [ML] update context fields * [ML] unit tests for getResultJobsHealthRuleConfig * [ML] refactor and job ids check * [ML] rename datafeed * [ML] fix translation messages * [ML] hide non-implemented tests * [ML] remove jod ids join from the getJobs call * [ML] add validation for the tests config * [ML] fix excluded jobs udpate * [ML] update jobIdsDescription message * [ML] allow selection all jobs only for include * [ML] better ux for excluded jobs setup * [ML] change rule type name * [ML] fix typo * [ML] change instances names * [ML] fix messages * [ML] hide error callout, show health checks error in EuiFormRow * [ML] add check for job state * [ML] add alertingRules key to the doc links * [ML] update types * [ML] remove redundant type * [ML] fix job and datafeed states check * [ML] fix job and datafeed states check, add comments * [ML] add unit tests # Conflicts: # src/core/public/doc_links/doc_links_service.ts Co-authored-by: Kibana Machine <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #101028
Adds new alerting rule type for monitoring anomaly detection jobs and groups.
This PR only contains a check for the datafeed state. The other tests will be added in follow-up PRs.
Checklist